Skip to content

ci: add a updated ci with linter check #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2024
Merged

ci: add a updated ci with linter check #9

merged 1 commit into from
Oct 24, 2024

Conversation

Pradumnasaraf
Copy link
Contributor

Issue

Closes #8

Chnages

  • Add a Go Linter check for incoming PR to analyse source code for errors, bugs, and other issues.

@vigneshs-dev
Copy link
Owner

image

I am experiencing the above errors for pull request from contributors. Can you solve this error along with the linter part?

@Pradumnasaraf
Copy link
Contributor Author

Pradumnasaraf commented Oct 24, 2024

I will fix that. I see you deleted the workflows folder, why?

@vigneshs-dev
Copy link
Owner

I will fix that. I see you deleted the workflows folder, why?

It's causing error. You can create the folder and create the files for github actions.

@Pradumnasaraf Pradumnasaraf changed the title ci: add a Go linter check ci: add a update ci with linter check Oct 24, 2024
@Pradumnasaraf Pradumnasaraf changed the title ci: add a update ci with linter check ci: add a updated ci with linter check Oct 24, 2024
@Pradumnasaraf
Copy link
Contributor Author

Hey, @vigneshs-dev

I have fixed the issue. Approve the workflow run in the PR and test.

@vigneshs-dev
Copy link
Owner

Thankyou for your contribution. Keep contributing.

@vigneshs-dev vigneshs-dev merged commit e7c83e4 into vigneshs-dev:main Oct 24, 2024
1 of 2 checks passed
@Pradumnasaraf Pradumnasaraf deleted the add-go-linter branch October 24, 2024 17:19
@Pradumnasaraf
Copy link
Contributor Author

Hey,

You merged the PR even though the CI was falling. The golangci/golangci-lint-action@v6 was falling and everything was working fine because you changed the project structure and it's not able to locate the go file.

@Pradumnasaraf
Copy link
Contributor Author

I have raised a PR for that #11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add Go a Linter in CI
2 participants